cross-compile

app/deps/.gitignore

@@ -0,0 +1,2 @@
+/data
+/target-*

app/deps/src/build-ffmpeg.sh

@@ -0,0 +1,64 @@
+#!/usr/bin/env bash
+. init_deps
+
+VERSION=5.0.1
+FILENAME=ffmpeg-$VERSION.tar.xz
+
+URL=http://ffmpeg.org/releases/ffmpeg-$VERSION.tar.xz
+SHA256SUM=ef2efae259ce80a240de48ec85ecb062cecca26e4352ffb3fda562c21a93007b
+
+DEP_DIR="$DATA_DIR/ffmpeg-$VERSION-$SHA256SUM"
+
+if [[ ! -d "$DEP_DIR" ]]
+then
+    get_file "$URL" "$FILENAME" "$SHA256SUM"
+
+    mkdir "$DEP_DIR"
+    cd "$DEP_DIR"
+
+    tar xvf "../$FILENAME"
+else
+    echo "$DEP_DIR found"
+    cd "$DEP_DIR"
+fi
+
+cd "ffmpeg-$VERSION"
+rm -rf "build-$HOST"
+mkdir "build-$HOST"
+cd "build-$HOST"
+
+params=(
+    --prefix="$INSTALL_DIR"
+    --arch="$ARCH"
+    --disable-autodetect
+    --disable-programs
+    --disable-everything
+    --disable-doc
+    --disable-swresample
+    --disable-swscale
+    --disable-avfilter
+    --disable-postproc
+    --disable-static
+    --enable-shared
+    --enable-decoder=h264
+    --enable-decoder=png
+    --enable-muxer=mp4
+    --enable-muxer=matroska
+)
+
+case "$HOST_SYSTEM" in
+    linux)
+        params+=(--enable-libv4l2)
+        ;;
+    windows)
+        params+=(--target-os=mingw32)
+        params+=(--cross-prefix="$HOST-")
+        ;;
+    *)
+        fail "Unsupported platform: $HOST"
+        ;;
+esac
+
+../configure "${params[@]}"
+make -j $NJOBS
+make install

app/deps/src/init_deps

@@ -0,0 +1,56 @@
+set -e
+
+# The caller must set the following environment variable
+#  - $HOST (e.g. "x86_64-linux-gnu")
+#  - $HOST_SYSTEM ("linux", "windows", "apple"), for scripts convenience
+
+fail() {
+    echo "$1" >&2
+    exit 1
+}
+
+[[ -z "$HOST" ]] && fail '$HOST not defined'
+
+if [[ "$HOST" == *linux* ]]
+then
+    HOST_SYSTEM='linux'
+elif [[ "$HOST" == *mingw* ]]
+then
+    HOST_SYSTEM='windows'
+else
+    fail "Host system could not be deduced from '$HOST'"
+fi
+
+ARCH="${HOST%%-*}"
+[[ -z "$ARCH" ]] && fail "Arch could not be deduced from '$HOST'"
+
+DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DIR"
+
+DATA_DIR=$(realpath ../data)
+INSTALL_DIR=$(realpath ../target-"$HOST")
+NJOBS=$(grep -c ^processor /proc/cpuinfo)
+
+mkdir -p "$DATA_DIR"
+cd "$DATA_DIR"
+
+checksum() {
+    local file="$1"
+    local sum="$2"
+    echo "$file: verifying checksum..."
+    echo "$sum  $file" | sha256sum -c
+}
+
+get_file() {
+    local url="$1"
+    local file="$2"
+    local sum="$3"
+    if [[ -f "$file" ]]
+    then
+        echo "$file: found"
+    else
+        echo "$file: not found, downloading..."
+        wget "$url" -O "$file"
+    fi
+    checksum "$file" "$sum"
+}

app/src/adb/adb.c

@@ -434,7 +434,6 @@ sc_adb_list_devices(struct sc_intr *intr, unsigned flags,
              "Please report an issue.");
         return false;
     }
-#undef BUFSIZE
 
     // It is parsed as a NUL-terminated string
     buf[r] = '\0';
@@ -711,97 +710,5 @@ sc_adb_get_device_ip(struct sc_intr *intr, const char *serial, unsigned flags) {
     // It is parsed as a NUL-terminated string
     buf[r] = '\0';
 
-    return sc_adb_parse_device_ip(buf);
-}
-
-char *
-sc_adb_get_installed_apk_path(struct sc_intr *intr, const char *serial,
-                              unsigned flags) {
-    assert(serial);
-    const char *const argv[] =
-        SC_ADB_COMMAND("-s", serial, "shell", "pm", "list", "package", "-f",
-                       SC_ANDROID_PACKAGE);
-
-    sc_pipe pout;
-    sc_pid pid = sc_adb_execute_p(argv, flags, &pout);
-    if (pid == SC_PROCESS_NONE) {
-        LOGD("Could not execute \"pm list packages\"");
-        return NULL;
-    }
-
-    // "pm list packages -f <package>" output should contain only one line, so
-    // the output should be short
-    char buf[1024];
-    ssize_t r = sc_pipe_read_all_intr(intr, pid, pout, buf, sizeof(buf) - 1);
-    sc_pipe_close(pout);
-
-    bool ok = process_check_success_intr(intr, pid, "pm list packages", flags);
-    if (!ok) {
-        return NULL;
-    }
-
-    if (r == -1) {
-        return NULL;
-    }
-
-    assert((size_t) r < sizeof(buf));
-    if (r == sizeof(buf) - 1)  {
-        // The implementation assumes that the output of "pm list packages"
-        // fits in the buffer in a single pass
-        LOGW("Result of \"pm list package\" does not fit in 1Kb. "
-             "Please report an issue.");
-        return NULL;
-    }
-
-    // It is parsed as a NUL-terminated string
-    buf[r] = '\0';
-
-    return sc_adb_parse_installed_apk_path(buf);
-}
-
-char *
-sc_adb_get_installed_apk_version(struct sc_intr *intr, const char *serial,
-                                 unsigned flags) {
-    assert(serial);
-    const char *const argv[] =
-        SC_ADB_COMMAND("-s", serial, "shell", "dumpsys", "package",
-                       SC_ANDROID_PACKAGE);
-
-    sc_pipe pout;
-    sc_pid pid = sc_adb_execute_p(argv, flags, &pout);
-    if (pid == SC_PROCESS_NONE) {
-        LOGD("Could not execute \"dumpsys package\"");
-        return NULL;
-    }
-
-    // "dumpsys package" output can be huge (e.g. 16k), but versionName is at
-    // the beginning, typically in the first 1024 bytes (64k should be enough
-    // for the whole output anyway)
-#define BUFSIZE 65536
-    char *buf = malloc(BUFSIZE);
-    if (!buf) {
-        return false;
-    }
-    ssize_t r = sc_pipe_read_all_intr(intr, pid, pout, buf, BUFSIZE - 1);
-    sc_pipe_close(pout);
-
-    bool ok = process_check_success_intr(intr, pid, "dumpsys package", flags);
-    if (!ok) {
-        return NULL;
-    }
-
-    if (r == -1) {
-        return NULL;
-    }
-
-    assert((size_t) r < BUFSIZE);
-#undef BUFSIZE
-    // if r == sizeof(buf), then the output is truncated, but we don't care,
-    // versionName is at the beginning in practice, and is unlikely to be
-    // truncated at 64k
-
-    // It is parsed as a NUL-terminated string
-    buf[r] = '\0';
-
-    return sc_adb_parse_installed_apk_version(buf);
+    return sc_adb_parse_device_ip_from_output(buf);
 }

app/src/adb/adb.h

@@ -15,8 +15,6 @@
 
 #define SC_ADB_SILENT (SC_ADB_NO_STDOUT | SC_ADB_NO_STDERR | SC_ADB_NO_LOGERR)
 
-#define SC_ANDROID_PACKAGE "com.genymobile.scrcpy"
-
 const char *
 sc_adb_get_executable(void);
 
@@ -116,18 +114,4 @@ sc_adb_getprop(struct sc_intr *intr, const char *serial, const char *prop,
 char *
 sc_adb_get_device_ip(struct sc_intr *intr, const char *serial, unsigned flags);
 
-/**
- * Return the path of the installed APK for com.genymobile.scrcpy (if any)
- */
-char *
-sc_adb_get_installed_apk_path(struct sc_intr *intr, const char *serial,
-                              unsigned flags);
-
-/**
- * Return the version of the installed APK for com.genymobile.scrcpy (if any)
- */
-char *
-sc_adb_get_installed_apk_version(struct sc_intr *intr, const char *serial,
-                                 unsigned flags);
-
 #endif

app/src/adb/adb_parser.c

@@ -199,7 +199,7 @@ sc_adb_parse_device_ip_from_line(char *line) {
 }
 
 char *
-sc_adb_parse_device_ip(char *str) {
+sc_adb_parse_device_ip_from_output(char *str) {
     size_t idx_line = 0;
     while (str[idx_line] != '\0') {
         char *line = &str[idx_line];
@@ -225,62 +225,3 @@ sc_adb_parse_device_ip(char *str) {
 
     return NULL;
 }
-
-char *
-sc_adb_parse_installed_apk_path(char *str) {
-    // str is expected to look like:
-    // "package:/data/app/.../base.apk=com.genymobile.scrcpy"
-    //          ^^^^^^^^^^^^^^^^^^^^^^
-    // We want to extract the path (which may contain '=', even in practice)
-
-    if (strncmp(str, "package:", 8)) {
-        // Does not start with "package:"
-        return NULL;
-    }
-
-    char *s = str + 8;
-    size_t len = strcspn(s, " \r\n");
-    s[len] = '\0';
-
-    char *p = strrchr(s, '=');
-    if (!p) {
-        // No '=' found
-        return NULL;
-    }
-
-    // Truncate at the last '='
-    *p = '\0';
-
-    return strdup(s);
-}
-
-char *
-sc_adb_parse_installed_apk_version(const char *str) {
-    // str is the (beginning of the) output of `dumpsys package`
-    // We want to extract the version string from a line starting with 4 spaces
-    // then `versionName=` then the version string.
-
-#define VERSION_NAME_PREFIX "\n    versionName="
-    char *s = strstr(str, VERSION_NAME_PREFIX);
-    if (!s) {
-        // Not found
-        return NULL;
-    }
-
-    s+= sizeof(VERSION_NAME_PREFIX) - 1;
-
-    size_t len = strspn(s, "0123456789.");
-    if (!len) {
-        LOGW("Unexpected version name with no value");
-        return NULL;
-    }
-
-    char *version = malloc(len + 1);
-    if (!version) {
-        return NULL;
-    }
-
-    memcpy(version, s, len);
-    version[len] = '\0';
-    return version;
-}

app/src/adb/adb_parser.h

@@ -25,26 +25,6 @@ sc_adb_parse_devices(char *str, struct sc_vec_adb_devices *out_vec);
  * Warning: this function modifies the buffer for optimization purposes.
  */
 char *
-sc_adb_parse_device_ip(char *str);
-
-/**
- * Parse the package path from the output of
- * `adb shell pm list packages -f <package>`
- *
- * The parameter must be a NUL-terminated string.
- *
- * Warning: this function modifies the buffer for optimization purposes.
- */
-char *
-sc_adb_parse_installed_apk_path(char *str);
-
-/**
- * Parse the package version from the output of
- * `adb shell dumpsys package <package>`
- *
- * The parameter must be a NUL-terminated string.
- */
-char *
-sc_adb_parse_installed_apk_version(const char *str);
+sc_adb_parse_device_ip_from_output(char *str);
 
 #endif

app/src/server.c

@@ -160,8 +160,6 @@ execute_server(struct sc_server *server,
     const char *serial = server->serial;
     assert(serial);
 
-    fprintf(stderr, "=== [%s]\n", sc_adb_get_installed_apk_version(&server->intr, serial, 0));
-
     const char *cmd[128];
     unsigned count = 0;
     cmd[count++] = sc_adb_get_executable();

app/src/stream.h

@@ -0,0 +1,51 @@
+#ifndef STREAM_H
+#define STREAM_H
+
+#include "common.h"
+
+#include <stdbool.h>
+#include <stdint.h>
+#include <libavcodec/avcodec.h>
+#include <libavformat/avformat.h>
+
+#include "trait/packet_sink.h"
+#include "util/net.h"
+#include "util/thread.h"
+
+#define STREAM_MAX_SINKS 2
+
+struct stream {
+    sc_socket socket;
+    sc_thread thread;
+
+    struct sc_packet_sink *sinks[STREAM_MAX_SINKS];
+    unsigned sink_count;
+
+    AVCodecContext *codec_ctx;
+    AVCodecParserContext *parser;
+    // successive packets may need to be concatenated, until a non-config
+    // packet is available
+    AVPacket *pending;
+
+    const struct stream_callbacks *cbs;
+    void *cbs_userdata;
+};
+
+struct stream_callbacks {
+    void (*on_eos)(struct stream *stream, void *userdata);
+};
+
+void
+stream_init(struct stream *stream, sc_socket socket,
+            const struct stream_callbacks *cbs, void *cbs_userdata);
+
+void
+stream_add_sink(struct stream *stream, struct sc_packet_sink *sink);
+
+bool
+stream_start(struct stream *stream);
+
+void
+stream_join(struct stream *stream);
+
+#endif

app/tests/test_adb_parser.c

@@ -5,7 +5,7 @@
 #include "adb/adb_device.h"
 #include "adb/adb_parser.h"
 
-static void test_adb_devices(void) {
+static void test_adb_devices() {
     char output[] =
         "List of devices attached\n"
         "0123456789abcdef	device usb:2-1 product:MyProduct model:MyModel "
@@ -31,7 +31,7 @@ static void test_adb_devices(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_cr(void) {
+static void test_adb_devices_cr() {
     char output[] =
         "List of devices attached\r\n"
         "0123456789abcdef	device usb:2-1 product:MyProduct model:MyModel "
@@ -57,7 +57,7 @@ static void test_adb_devices_cr(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_daemon_start(void) {
+static void test_adb_devices_daemon_start() {
     char output[] =
         "* daemon not running; starting now at tcp:5037\n"
         "* daemon started successfully\n"
@@ -78,7 +78,7 @@ static void test_adb_devices_daemon_start(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_daemon_start_mixed(void) {
+static void test_adb_devices_daemon_start_mixed() {
     char output[] =
         "List of devices attached\n"
         "adb server version (41) doesn't match this client (39); killing...\n"
@@ -105,7 +105,7 @@ static void test_adb_devices_daemon_start_mixed(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_without_eol(void) {
+static void test_adb_devices_without_eol() {
     char output[] =
         "List of devices attached\n"
         "0123456789abcdef	device usb:2-1 product:MyProduct model:MyModel "
@@ -124,7 +124,7 @@ static void test_adb_devices_without_eol(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_adb_devices_without_header(void) {
+static void test_adb_devices_without_header() {
     char output[] =
         "0123456789abcdef	device usb:2-1 product:MyProduct model:MyModel "
             "device:MyDevice transport_id:1\n";
@@ -134,7 +134,7 @@ static void test_adb_devices_without_header(void) {
     assert(!ok);
 }
 
-static void test_adb_devices_corrupted(void) {
+static void test_adb_devices_corrupted() {
     char output[] =
         "List of devices attached\n"
         "corrupted_garbage\n";
@@ -145,7 +145,7 @@ static void test_adb_devices_corrupted(void) {
     assert(vec.size == 0);
 }
 
-static void test_adb_devices_spaces(void) {
+static void test_adb_devices_spaces() {
     char output[] =
         "List of devices attached\n"
         "0123456789abcdef       unauthorized usb:1-4 transport_id:3\n";
@@ -163,132 +163,84 @@ static void test_adb_devices_spaces(void) {
     sc_adb_devices_destroy(&vec);
 }
 
-static void test_get_ip_single_line(void) {
+static void test_get_ip_single_line() {
     char ip_route[] = "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.12.34\r\r\n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(ip);
     assert(!strcmp(ip, "192.168.12.34"));
     free(ip);
 }
 
-static void test_get_ip_single_line_without_eol(void) {
+static void test_get_ip_single_line_without_eol() {
     char ip_route[] = "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.12.34";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(ip);
     assert(!strcmp(ip, "192.168.12.34"));
     free(ip);
 }
 
-static void test_get_ip_single_line_with_trailing_space(void) {
+static void test_get_ip_single_line_with_trailing_space() {
     char ip_route[] = "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.12.34 \n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(ip);
     assert(!strcmp(ip, "192.168.12.34"));
     free(ip);
 }
 
-static void test_get_ip_multiline_first_ok(void) {
+static void test_get_ip_multiline_first_ok() {
     char ip_route[] = "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.1.2\r\n"
                       "10.0.0.0/24 dev rmnet  proto kernel  scope link  src "
                       "10.0.0.2\r\n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(ip);
     assert(!strcmp(ip, "192.168.1.2"));
     free(ip);
 }
 
-static void test_get_ip_multiline_second_ok(void) {
+static void test_get_ip_multiline_second_ok() {
     char ip_route[] = "10.0.0.0/24 dev rmnet  proto kernel  scope link  src "
                       "10.0.0.3\r\n"
                       "192.168.1.0/24 dev wlan0  proto kernel  scope link  src "
                       "192.168.1.3\r\n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(ip);
     assert(!strcmp(ip, "192.168.1.3"));
     free(ip);
 }
 
-static void test_get_ip_no_wlan(void) {
+static void test_get_ip_no_wlan() {
     char ip_route[] = "192.168.1.0/24 dev rmnet  proto kernel  scope link  src "
                       "192.168.12.34\r\r\n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(!ip);
 }
 
-static void test_get_ip_no_wlan_without_eol(void) {
+static void test_get_ip_no_wlan_without_eol() {
     char ip_route[] = "192.168.1.0/24 dev rmnet  proto kernel  scope link  src "
                       "192.168.12.34";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(!ip);
 }
 
-static void test_get_ip_truncated(void) {
+static void test_get_ip_truncated() {
     char ip_route[] = "192.168.1.0/24 dev rmnet  proto kernel  scope link  src "
                       "\n";
 
-    char *ip = sc_adb_parse_device_ip(ip_route);
+    char *ip = sc_adb_parse_device_ip_from_output(ip_route);
     assert(!ip);
 }
 
-static void test_apk_path(void) {
-    char str[] = "package:/data/app/~~71mguyc6p-kNjQdNaNkToA==/com.genymobile."
-                 "scrcpy-l6fiqqUSU7Ok7QLg-rIyJA==/base.apk=com.genymobile."
-                 "scrcpy\n";
-
-    const char *expected = "/data/app/~~71mguyc6p-kNjQdNaNkToA==/com.genymobile"
-                           ".scrcpy-l6fiqqUSU7Ok7QLg-rIyJA==/base.apk";
-    char *path = sc_adb_parse_installed_apk_path(str);
-    assert(!strcmp(path, expected));
-    free(path);
-}
-
-static void test_apk_path_invalid(void) {
-    // Does not start with "package:"
-    char str[] = "garbage:/data/app/~~71mguyc6p-kNjQdNaNkToA==/com.genymobile."
-                 "scrcpy-l6fiqqUSU7Ok7QLg-rIyJA==/base.apk=com.genymobile."
-                 "scrcpy\n";
-
-    char *path = sc_adb_parse_installed_apk_path(str);
-    assert(!path);
-}
-
-static void test_apk_version(void) {
-    char str[] =
-        "Key Set Manager:\n"
-        "  [com.genymobile.scrcpy]\n"
-        "      Signing KeySets: 128\n"
-        "\n"
-        "Packages:\n"
-        "  Package [com.genymobile.scrcpy] (89abcdef):\n"
-        "    userId=12345\n"
-        "    pkg=Package{012345 com.genymobile.scrcpy}\n"
-        "    codePath=/data/app/~~abcdef==/com.genymobile.scrcpy-012345==\n"
-        "    resourcePath=/data/app/~~abcdef==/com.genymobile.scrcpy-013245==\n"
-        "    primaryCpuAbi=null\n"
-        "    secondaryCpuAbi=null\n"
-        "    versionCode=12400 minSdk=21 targetSdk=31\n"
-        "    versionName=1.24\n"
-        "    splits=[base]\n"
-        "    apkSigningVersion=2\n"
-        "    applicationInfo=ApplicationInfo{012345 com.genymobile.scrcpy}\n";
-
-    const char *expected = "1.24";
-    char *version = sc_adb_parse_installed_apk_version(str);
-    assert(!strcmp(version, expected));
-    free(version);
-}
-
 int main(int argc, char *argv[]) {
     (void) argc;
     (void) argv;
@@ -310,10 +262,4 @@ int main(int argc, char *argv[]) {
     test_get_ip_no_wlan();
     test_get_ip_no_wlan_without_eol();
     test_get_ip_truncated();
-
-    test_apk_path();
-    test_apk_path_invalid();
-    test_apk_version();
-
-    return 0;
 }