1302 Commits

Author SHA1 Message Date
Romain Vimont
2b2cf0a1c5 Add compat support for FFmpeg < 5.1
The new chlayout API has been introduced in FFmpeg 5.1. Use the old
channel_layout API on older versions.
2023-02-27 21:41:27 +01:00
Romain Vimont
0e08a1e484 Add audio player
Play the decoded audio using SDL.

The audio player frame sink receives the audio frames, resample them
and write them to a byte buffer (introduced by this commit).

On SDL audio callback (from an internal SDL thread), copy samples from
this byte buffer to the SDL audio buffer.

The byte buffer is protected by the SDL_AudioDeviceLock(), but it has
been designed so that the producer and the consumer may write and read
in parallel, provided that they don't access the same slices of the
ring-buffer buffer.

Co-authored-by: Simon Chan <1330321+yume-chan@users.noreply.github.com>
2023-02-27 20:53:14 +01:00
Romain Vimont
e2b065bc4a Add two-step write feature to bytebuf
If there is exactly one producer, then it can assume that the remaining
space in the buffer will only increase until it write something.

This assumption may allow the producer to write to the buffer (up to a
known safe size) without any synchronization mechanism, thus allowing
to read and write different parts of the buffer in parallel.

The producer can then commit the write with lock held, and update its
knowledge of the safe empty remaining space.
2023-02-27 20:53:14 +01:00
Romain Vimont
c91727c086 Introduce bytebuf util
Add a ring-buffer for bytes. It will be useful for buffering audio.
2023-02-27 20:53:14 +01:00
Romain Vimont
2a26c279c5 Pass AVCodecContext to frame sinks
Frame consumers may need details about the frame format.
2023-02-27 20:53:14 +01:00
Romain Vimont
38f8cb1357 Add an audio decoder 2023-02-27 20:53:14 +01:00
Romain Vimont
b856db7239 Give a name to decoder instances
This will be useful in logs.
2023-02-27 20:53:14 +01:00
Romain Vimont
b70cb2ff7c Rename decoder to video_decoder 2023-02-27 20:53:14 +01:00
Romain Vimont
a7af7d9844 Add --list-device-displays 2023-02-27 20:53:14 +01:00
Romain Vimont
bbf9df265e Quit on audio configuration failure
When audio capture fails on the device, scrcpy continue mirroring the
video stream. This allows to enable audio by default only when
supported.

However, if an audio configuration occurs (for example the user
explicitly selected an unknown audio encoder), this must be treated as
an error and scrcpy must exit.
2023-02-27 20:53:14 +01:00
Romain Vimont
001b62917e Add --list-encoders
Add an option to list the device encoders properly.
2023-02-27 20:53:14 +01:00
Romain Vimont
cbc0cef95d Move await_for_server() logs
Print the logs on the caller side. This will allow to call the function
in another context without printing the logs.
2023-02-27 20:53:14 +01:00
Romain Vimont
754b3aff14 Add --audio-encoder
Similar to --video-encoder, but for audio.
2023-02-27 20:53:14 +01:00
Romain Vimont
160e00ff43 Add --audio-codec-options
Similar to --video-codec-options, but for audio.
2023-02-27 20:53:14 +01:00
Romain Vimont
6f5326a4bf Add support for AAC audio codec
Add option --audio-codec=aac.
2023-02-27 20:53:14 +01:00
Romain Vimont
9da5285561 Add --audio-codec
Introduce the selection mechanism. Alternative codecs will be added
later.
2023-02-27 20:53:14 +01:00
Romain Vimont
1966c4df4b Add --audio-bit-rate
Add an option to configure the audio bit-rate.
2023-02-27 20:53:14 +01:00
Romain Vimont
b3586f32f7 Rename --encoder to --video-encoder
This prepares the introduction of --audio-encoder.
2023-02-27 20:53:14 +01:00
Romain Vimont
38a7dcd83c Rename --codec-options to --video-codec-options
This prepares the introduction of --audio-codec-options.
2023-02-27 20:53:14 +01:00
Romain Vimont
0c2e2b998d Rename --bit-rate to --video-bit-rate
This prepares the introduction of --audio-bit-rate.
2023-02-27 20:53:14 +01:00
Romain Vimont
3513fc7809 Rename --codec to --video-codec
This prepares the introduction of --audio-codec.
2023-02-27 20:53:14 +01:00
Romain Vimont
fef75277bc Remove default bit-rate on client side
If no bit-rate is passed, let the server use the default value (8Mbps).

This avoids to define a default value on both sides, and to pass the
default bit-rate as an argument when starting the server.
2023-02-27 20:53:14 +01:00
Romain Vimont
5192891fc8 Record at least video packets on stop
If the recorder is stopped while it has not received any audio packet
yet, make sure the video stream is correctly recorded.
2023-02-27 20:53:14 +01:00
Romain Vimont
b814ca84df Disable audio on initialization error
By default, audio is enabled (--no-audio must be explicitly passed to
disable it).

However, some devices may not support audio capture (typically devices
below Android 11, or Android 11 when the shell application is not
foreground on start).

In that case, make the server notify the client to dynamically disable
audio forwarding so that it does not wait indefinitely for an audio
stream.

Also disable audio on unknown codec or missing decoder on the
client-side, for the same reasons.
2023-02-27 20:53:14 +01:00
Romain Vimont
f095f61d65 Add record audio support
Make the recorder accept two input sources (video and audio), and mux
them into a single file.
2023-02-27 20:53:14 +01:00
Romain Vimont
69ebf8a578 Rename video-specific variables in recorder
This paves the way to add audio-specific variables.
2023-02-27 20:53:14 +01:00
Romain Vimont
067cea8674 Do not merge config audio packets
For video streams (at least H.264 and H.265), the config packet
containing SPS/PPS must be prepended to the next packet (the following
keyframe).

For audio streams (at least OPUS), they must not be merged.
2023-02-27 20:53:14 +01:00
Romain Vimont
59ffc76d4e Add an audio demuxer
Add a demuxer which will read the stream from the audio socket.
2023-02-27 20:53:14 +01:00
Romain Vimont
3c702afdb0 Give a name to demuxer instances
This will be useful in logs.
2023-02-27 20:53:14 +01:00
Romain Vimont
d652e49001 Rename demuxer to video_demuxer
There will be another demuxer instance for audio.
2023-02-27 20:53:14 +01:00
Simon Chan
e55db52ed9 Add a new socket for audio stream
When audio is enabled, open a new socket to send the audio stream from
the device to the client.

Co-authored-by: Romain Vimont <rom@rom1v.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
2023-02-27 20:53:14 +01:00
Simon Chan
73ff2d730d Add --no-audio option
Audio will be enabled by default (when supported). Add an option to
disable it.

Co-authored-by: Romain Vimont <rom@rom1v.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
2023-02-27 20:53:14 +01:00
Romain Vimont
0075b97976 Reorder initialization
Initialize components in the pipeline order: demuxer first, decoder and
recorder second.
2023-02-27 20:53:14 +01:00
Romain Vimont
a3f8239da7 Refactor recorder logic
Process the initial config packet (necessary to write the header)
separately.
2023-02-27 20:53:14 +01:00
Romain Vimont
6d5806ef5c Move last packet recording
Write the last packet at the end.
2023-02-27 20:53:14 +01:00
Romain Vimont
3a5e065a08 Add start() function for recorder
For consistency with the other components, do not start the internal
thread from an init() function.
2023-02-27 20:53:14 +01:00
Romain Vimont
620cd7b19a Open recording file from the recorder thread
The recorder opened the target file from the packet sink open()
callback, called by the demuxer. Only then the recorder thread was
started.

One golden rule for the recorder is to never block the demuxer for I/O,
because it would impact mirroring. This rule is respected on recording
packets, but not for the initial recorder opening.

Therefore, start the recorder thread from sc_recorder_init(), open the
file immediately from the recorder thread, then make it wait for the
stream to start (on packet sink open()).

Now that the recorder can report errors directly (rather than making the
demuxer call fail), it is possible to report file opening error even
before the packet sink is open.
2023-02-27 20:53:14 +01:00
Romain Vimont
099b83484c Inline packet_sink impl in recorder
Remove useless wrappers.
2023-02-27 20:53:14 +01:00
Romain Vimont
dceef8f279 Initialize recorder fields from init()
The recorder has two initialization phases: one to initialize the
concrete recorder object, and one to open its packet_sink trait.

Initialize mutex and condvar as part of the object initialization.

If there were several packet_sink traits, the mutex and condvar would
still be initialized only once.
2023-02-27 20:53:14 +01:00
Romain Vimont
e26ed27575 Report recorder errors
Stop scrcpy on recorder errors.

It was previously indirectly stopped by the demuxer, which failed to
push packets to a recorder in error. Report it directly instead:
 - it avoids to wait for the next demuxer call;
 - it will allow to open the target file from a separate thread and stop
   immediately on any I/O error.
2023-02-27 20:53:14 +01:00
Romain Vimont
de796552bd Move previous packet to a local variable
It is only used from run_recorder().
2023-02-27 20:53:14 +01:00
Romain Vimont
1330f58689 Move pts_origin to a local variable
It is only used from run_recorder().
2023-02-27 20:53:14 +01:00
Romain Vimont
a55c177e7d Change PTS origin type from uint64_t to int64_t
It is initialized from AVPacket.pts, which is an int64_t.
2023-02-27 20:53:14 +01:00
Romain Vimont
3e5cf55dd8 Fix --encoder documentation
Mention that it depends on the codec provided by --codec (which is not
necessarily H264 anymore).
2023-02-27 20:53:14 +01:00
Romain Vimont
a51e500584 Fix --no-clipboard-autosync bash completion
Fix typo.
2023-02-27 20:53:14 +01:00
Romain Vimont
eac38013f7 Split server stop() and join()
For consistency with the other components, call stop() and join()
separately.

This allows to stop all components, then join them all.
2023-02-27 20:53:14 +01:00
Romain Vimont
dad8ab02bd Print FFmpeg logs
FFmpeg logs are redirected to a specific SDL log category.

Initialize the log level for this category to print them as expected.
2023-02-27 20:53:14 +01:00
Romain Vimont
0c8144a5cd Move FFmpeg callback initialization
Configure FFmpeg log redirection on start from a log helper.
2023-02-27 20:53:14 +01:00
Romain Vimont
6b422e21bf Fix error message on icon loading failure 2023-02-27 20:51:54 +01:00
Romain Vimont
8e8b039a63 Do not use avformat network
Scrcpy does not use FFmpeg network features. Initialize network locally
instead (useful only for Windows).

The include block has been moved to fix the following warning:

    Please include winsock2.h before windows.h
2023-02-27 20:51:54 +01:00