pei/scrcpy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify process_wait()

Browse Source 
The function process_wait() returned a bool (true if the process
terminated successfully) and provided the exit code via an output
parameter exit_code.

But the returned value was always equivalent to exit_code == 0, so just
return the exit code instead.
This commit is contained in:
Romain Vimont
2021-01-22 18:29:21 +01:00
parent 94eff0a4bb
commit b8edcf52b0
6 changed files with 30 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/util/process.c
View File

@@ -8,8 +8,8 @@ process_check_success(process_t proc, const char *name) {
LOGE("Could not execute \"%s\"", name);
return false;
}
exit_code_t exit_code;
if (!process_wait(proc, &exit_code)) {
exit_code_t exit_code = process_wait(proc);
if (exit_code) {
if (exit_code != NO_EXIT_CODE) {
LOGE("\"%s\" returned with value %" PRIexitcode, name, exit_code);
} else {

8
app/src/util/process.h
View File

@@ -47,12 +47,12 @@ bool
process_terminate(process_t pid);
// wait and close the process (like waitpid())
bool
process_wait(process_t pid, exit_code_t *exit_code);
exit_code_t
process_wait(process_t pid);
// wait (but does not close) the process (waitid() with WNOWAIT)
bool
process_wait_noclose(process_t pid, exit_code_t *exit_code);
exit_code_t
process_wait_noclose(process_t pid);
// close the process
//