Replace SDL_net by custom implementation
SDL_net is not very suitable for scrcpy. For example, SDLNet_TCP_Accept() is non-blocking, so we have to wrap it by calling many SDL_Net-specific functions to make it blocking. But above all, SDLNet_TCP_Open() is a server socket only when no IP is provided; otherwise, it's a client socket. Therefore, it is not possible to create a server socket bound to localhost, so it accepts connections from anywhere. This is a problem for scrcpy, because on start, the application listens for nearly 1 second until it accepts the first connection, supposedly from the device. If someone on the local network manages to connect to the server socket first, then they can stream arbitrary H.264 video. This may be troublesome, for example during a public presentation ;-) Provide our own simplified API (net.h) instead, implemented for the different platforms.
This commit is contained in:
16
app/src/sys/unix/net.c
Normal file
16
app/src/sys/unix/net.c
Normal file
@@ -0,0 +1,16 @@
|
||||
#include "../../net.h"
|
||||
|
||||
# include <unistd.h>
|
||||
|
||||
SDL_bool net_init(void) {
|
||||
// do nothing
|
||||
return SDL_TRUE;
|
||||
}
|
||||
|
||||
void net_cleanup(void) {
|
||||
// do nothing
|
||||
}
|
||||
|
||||
void net_close(socket_t socket) {
|
||||
close(socket);
|
||||
}
|
||||
Reference in New Issue
Block a user